Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #1180: Only load enabled extension packages #1204

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from

Conversation

gogasca
Copy link
Contributor

@gogasca gogasca commented Feb 6, 2023

No description provided.

@welcome
Copy link

welcome bot commented Feb 6, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@gogasca
Copy link
Contributor Author

gogasca commented Feb 6, 2023

FAILED tests/extension/test_manager.py::test_extension_package_api - AttributeError: 'ExtensionPackage' object has no attribute 'log'
FAILED tests/extension/test_manager.py::test_extension_package_notfound_error - AttributeError: 'ExtensionPackage' object has no attribute 'log'
FAILED tests/extension/test_manager.py::test_extension_manager_api - assert 0 == 1

@blink1073
Copy link
Contributor

It looks like this can't be cleanly backported, due to lifecycle differences at startup between 1.x and 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants