Add id to buttons in launch form #1954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
rgaiacs
force-pushed
the
add-id-to-elements
branch
from
528a520 to
d61fce1
Compare
|
@yuvipanda I want to go ahead and merge this. Let me know if you need more time to review. |
consideRatio
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
I skimmed other id attributes and saw @yuvipanda adding some earlier with the prefix btn- for buttons, I figure aligning with that practice could make sense.
Besides that I can't see a reason to hold off a merge!
ids are prefixed with "btn-" as existing ones.
rgaiacs
force-pushed
the
add-id-to-elements
branch
from
8d9b98e to
cb982fc
Compare
Thanks for this. I updated this pull request to follow the existing practice. |
github-project-automation
bot
moved this from Backlog
to Done
in PR triage (experimental)
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Sep 9, 2025
jupyterhub/binderhub#1954 Merge pull request #1954 from rgaiacs/add-id-to-elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on jupyterhub/mybinder.org-deploy#3264, I was having problems to apply the CSS to the buttons. Because we only have a very limited number of buttons, I added a
idto each one of the buttons. This helped me to apply the CSS because theidhas priority overclass.