Skip to content

Conversation

paololazzari
Copy link
Contributor

No description provided.

@rgaiacs
Copy link
Contributor

rgaiacs commented Sep 9, 2025

I think that we already fixed the reason why the test was failing. @paololazzari could you rebase this pull request for us to verify the test?

@rgaiacs rgaiacs added documentation code:helm-chart Helm template changes. labels Sep 9, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in PR triage (experimental) Sep 9, 2025
@consideRatio consideRatio reopened this Sep 9, 2025
@consideRatio
Copy link
Member

I think by close/re-open the PR, the tests will re-run against on the PR merged into the main branch I think - lets see if it resolves @rgaiacs!

Copy link
Contributor

@rgaiacs rgaiacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the securityContext but this pull request is about improve documentation. It looks good to me.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In z2jh, we default to constraining pods/containers using securityContexts'. I figure we should do it in this helm chart as well.

https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/bac149a96cca0179e01757ce9c85e0d227ebfd01/jupyterhub/values.yaml#L94-L104

@consideRatio consideRatio merged commit 5579504 into jupyterhub:main Sep 9, 2025
25 of 26 checks passed
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code:helm-chart Helm template changes. documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants