Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override xstartup with environment variable #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manics
Copy link
Member

@manics manics commented Nov 4, 2024

Defines the variable JUPYTER_REMOTE_DESKTOP_PROXY_XSTARTUP to launch a custom xstartup script.

The main benefit of this is launching a different desktop e.g. https://github.com/manics/jupyter-desktop-mate/blob/main/start-mate.sh on a system where a user's home directory may be mounted, meaning ~/.vnc/xstartup doesn't exist.

Ideally this would be done with a traitlets configuration so it could be specified in one of the standard configuration paths, but the VNC server and desktop are launched using a custom jupyter-server-proxy entrypoint

'jupyter_serverproxy_servers': [
'desktop-websockify = jupyter_remote_desktop_proxy.setup_websockify:setup_websockify',
]

so as far as I know it's not possible to pass a traitlets configuration object to it.

Defines the variable `JUPYTER_REMOTE_DESKTOP_PROXY_XSTARTUP` to launch a custom xstartup script
@manics manics added the enhancement New feature or request label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Binder 👈 Launch a binder notebook on this branch for commit 3a025bb

I will automatically update this comment whenever this PR is modified

@manics
Copy link
Member Author

manics commented Nov 6, 2024

I've been prototyping a configurable entrypoint in jupyterhub/jupyter-server-proxy@58e5667 (jupyterhub/jupyter-server-proxy#509)

I'm undecided on what's better though, an env-var or the configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants