Test bind_dn_template more thoroughly #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
`lookup_dn` needs to be True here, because the `{username}` expansion in the `bind_dn_template` string will without it expand to fry as a login name, but needs to be expanded to `Philip J. Fry` as that is the `fry` user's cn attribute, and only such expanded dn template will successfully be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lookup_dn=Trueinldapauthenticator/ldapauthenticator/tests/conftest.py
Line 14 in 46bc7e6
meant the bug fixed in #289 wasn't tested.