Disable image cleaner #3249
Merged
Disable image cleaner #3249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of jupyterhub/binderhub#1941, I want to not port imageCleaner to the new chart. Since the image store is not really used to push anymore (since jupyterhub/repo2docker#1421) and we will be able to disregard it completely in the future, we can simply just prune the entire image store than do any complex logic here.
|
Cronjobs only run on one node at a time- are we sure they'll be randomly scheduled across all build nodes at a frequent enough interval? |
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Mar 10, 2025
This is practically a no-op, but we want imageCleaner enabled still on multi-node instances See jupyterhub#3249 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of jupyterhub/binderhub#1941, I want to not port imageCleaner to the new chart. Since the image store is not really used to push anymore (since jupyterhub/repo2docker#1421) and we will be able to disregard it completely in the future, we can simply just prune the entire image store than do any complex logic here.