Skip to content

Commit

Permalink
Merge pull request #770 from jupyterlab/allow-python-symlinks-in-envs
Browse files Browse the repository at this point in the history
allow python symlinks in environments
  • Loading branch information
mbektas authored Feb 16, 2024
2 parents 56e4061 + c3d66ae commit 23fec56
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/main/registry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ export class Registry implements IRegistry, IDisposable {
}

// discover environments on system
// TODO: rediscover environments in app's envs directory
const pathEnvironments = this._loadPathEnvironments();
const condaEnvironments = this._loadCondaEnvironments();
const allEnvironments = [pathEnvironments, condaEnvironments];
Expand Down Expand Up @@ -284,9 +283,7 @@ export class Registry implements IRegistry, IDisposable {
sort?: boolean
): Promise<IPythonEnvironment[]> {
let filteredEnvs = envs.filter(env => this._pathExistsSync(env.path));
const uniqueEnvs = this._getUniqueObjects(filteredEnvs, env => {
return fs.realpathSync(env.path);
});
const uniqueEnvs = this._getUniqueObjects(filteredEnvs);
const resolvedEnvs = await Promise.all(
uniqueEnvs.map(async env => await this._resolveEnvironment(env.path))
);
Expand Down

0 comments on commit 23fec56

Please sign in to comment.