Skip to content

Commit

Permalink
Merge pull request #758 from jupyterlab/release-v4.0.12-1
Browse files Browse the repository at this point in the history
Release v4.0.12-1
  • Loading branch information
mbektas authored Feb 2, 2024
2 parents fba90b6 + 5aa4e61 commit 61fbada
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,3 @@ __pycache__

env_installer/jlab_server/
env_installer/jlab_server.tar.gz

6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ JupyterLab Desktop is the cross-platform desktop application for [JupyterLab](ht

If you have an existing JupyterLab Desktop installation, please uninstall it first by following the [uninstall instructions](user-guide.md#uninstalling-jupyterlab-desktop).

- [Debian, Ubuntu Linux Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Debian.deb)
- [Red Hat, Fedora, SUSE Linux Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Fedora.rpm)
- [Debian, Ubuntu Linux Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Debian-x64.deb)
- [Red Hat, Fedora, SUSE Linux Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Fedora-x64.rpm)
- [macOS Intel Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-macOS-x64.dmg), [macOS Apple silicon Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-macOS-arm64.dmg)
- [Windows Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Windows.exe)
- [Windows Installer](https://github.com/jupyterlab/jupyterlab-desktop/releases/latest/download/JupyterLab-Setup-Windows-x64.exe)

Additionally, JupyterLab Desktop can be installed on Windows via winget: `winget install jupyterlab`.

Expand Down
4 changes: 2 additions & 2 deletions src/main/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -537,10 +537,10 @@ export async function createPythonEnvironment(
} else {
const systemPythonPath = getSystemPythonPath();
if (condaBaseEnvExists) {
const createCommand = `python -m venv create ${envPath}`;
const createCommand = `python -m venv ${envPath}`;
await runCommandInEnvironment(baseCondaEnvPath, createCommand, callbacks);
} else if (fs.existsSync(systemPythonPath)) {
execFileSync(systemPythonPath, ['-m', 'venv', 'create', envPath]);
execFileSync(systemPythonPath, ['-m', 'venv', envPath]);
} else {
throw new Error(
'Failed to create Python environment. Python executable not found.'
Expand Down
2 changes: 1 addition & 1 deletion src/main/pythonenvdialog/pythonenvdialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,7 @@ export class ManagePythonEnvironmentDialog {
createCommandPreview.value = \`conda create -p \$\{getEnvInstallPath()\} \$\{getCondaChannels()\}\ \$\{getPackageList()\}\`;
} else {
const envPath = getEnvInstallPath();
createCommandPreview.value = \`python -m venv create \$\{envPath\}\n\$\{envPath\}\$\{pathSeparator\}${activateRelPath.replace(
createCommandPreview.value = \`python -m venv \$\{envPath\}\n\$\{envPath\}\$\{pathSeparator\}${activateRelPath.replace(
'\\',
'\\\\'
)}\npython -m pip install \$\{getPackageList()\}\`;
Expand Down

0 comments on commit 61fbada

Please sign in to comment.