-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snap package #751
Snap package #751
Conversation
Contains additional properties to make the shell commands work from within the strict confinement. JP Desktop uses the SHELL environment variable to launch a shell command and if SHELL is different from what is available in the snap's core (e.g. /usr/bin/zsh), the command would fail. Thus, bash is ensured as the SHELL option
* The snap's confinement mode is switched to classic. Mostly because JL Server creates hidden and temp files in a jupyter notebook directory it has open (e.g. for checkpoints or when it saves the file). Thus, if a user has a notebook stored in $HOME, JLD fails to save it with a permission denied error. It cannot be resolved with the snap's personal-files interface as the interface allows to specify existing paths only.
Thanks for submitting your first pull request! You are awesome! 🤗 |
@dmitry-lyfar I tested these changes locally (on a Ubuntu aarch64) and ran into the problems below. do you know of solutions for these by changing the snap configuration? or do we have to make changes to app code?
|
Hi @mbektas,
Yes, this is because snaps are not distributed as standalone archives. When we publish, a user would be able to do
By default, the data created within snap user directories is snapshotted and stored for, I believe, 30 days (see |
Description
Adds snap package building and publishing.
@mbektas I have not registered a snap name as it should probably be done under Jupyter Project publisher. When registered, we can obtain the store credentials and have the publishing workflow working. Also, when done, we would need to apply for the classic snap approval as only the strict ones are allowed for automatic publishing (I can take care of that as well).