Skip to content

Update to @jupyter/chat 0.14.0 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 23, 2025

Update to https://github.com/jupyterlab/jupyter-chat/releases/tag/v0.14.0

jupyterlite-ai-jupyter-chat-014.mp4

@jtpio jtpio added the enhancement New feature or request label Jun 23, 2025
@jtpio jtpio marked this pull request as ready for review June 23, 2025 17:12
@jtpio jtpio requested a review from brichet June 23, 2025 17:12
Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio, looks good.

I just have a comment about dependencies, but this is not required, it's me who's the maniac about that 😄

Comment on lines +975 to +976
"@jupyterlab/codeeditor": ^4.2.0
"@jupyterlab/codemirror": ^4.2.0
Copy link
Collaborator

@brichet brichet Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if it matter (maybe to avoid futures possible conflicts in dependencies), but we could try to homogenize these packages, that should homogenize their dependencies.

Copy link
Member Author

@jtpio jtpio Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I tried to deduplicate the dependencies in the first commit but it seemed to be causing issues with settings script, which got fixed after 906caa1 and reverting the deduplication.

Looks like the deduplication somehow ensured the version of other dependencies, interfering a little bit with this update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can open a separate PR to try to fix the yarn.lock with something like:

jlpm dlx yarn-berry-deduplicate -s fewerHighest && jlpm install

@brichet brichet merged commit 77b5cf8 into jupyterlite:main Jun 24, 2025
9 checks passed
@jtpio jtpio deleted the bump-jupyter-chat branch June 24, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants