Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser-check test #23

Closed
wants to merge 1 commit into from
Closed

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Dec 17, 2024

Related to jupyterlab/jupyterlab#17079

Thanks @trungleduc for the pointer.

@jtpio
Copy link
Member

jtpio commented Dec 18, 2024

FYI there is likely a fix coming in the next JupyterLab 4.3.4: jupyterlab/jupyterlab#17094

@brichet
Copy link
Collaborator Author

brichet commented Dec 18, 2024

FYI there is likely a fix coming in the next JupyterLab 4.3.4: jupyterlab/jupyterlab#17094

🎉 nice, so maybe we should open an issue to track it and remove these changes when the CI are using 4.3.4

@jtpio
Copy link
Member

jtpio commented Dec 18, 2024

Yes, or wait for 4.3.4 which could be released today (as discussed on Zulip).

@krassowski
Copy link

This should no longer be needed as 4.3.4 is out and CI elsewhere is confirmed to be passing :)

@jtpio
Copy link
Member

jtpio commented Dec 18, 2024

This should no longer be needed as 4.3.4 is out and CI elsewhere is confirmed to be passing :)

Confirmed here after restarting a failing check in another PR. Thanks for the fix and the release!

@brichet
Copy link
Collaborator Author

brichet commented Dec 18, 2024

Thanks @krassowski and @jtpio.
Closing this as fixed.

@brichet brichet closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants