Skip to content

Add UI tests #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025
Merged

Add UI tests #97

merged 5 commits into from
Jun 17, 2025

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jun 16, 2025

This PR adds first UI tests, including:

  • test the chat panel (button, opening, welcome message)
  • error message if there is no AI provider
  • AI response if the AI provider is set
  • AI code completion if the AI provider is set

Fixes #67

@brichet brichet changed the title Add UI test Add UI tests Jun 17, 2025
@brichet brichet marked this pull request as ready for review June 17, 2025 09:40
@brichet
Copy link
Collaborator Author

brichet commented Jun 17, 2025

The test on code completion seems to work well, but I wonder how stable it will be in the future.
Currently it checks if the ghost text is visible, and also if the request has been send.
If the ghost text fails too often, we can remove the ghost text check.

@jtpio
Copy link
Member

jtpio commented Jun 17, 2025

The test on code completion seems to work well, but I wonder how stable it will be in the future.
Currently it checks if the ghost text is visible, and also if the request has been send.
If the ghost text fails too often, we can remove the ghost text check.

yeah that's also what I was wondering. Otherwise maybe we would need to trigger the completion several time and check that it shows up at least once?

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 456c91d into jupyterlite:main Jun 17, 2025
12 checks passed
@brichet brichet deleted the ui-tests branch June 18, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI tests
2 participants