fix: remove export kernel settings schema json#47
Open
echarles wants to merge 1 commit intojupyterlite:mainfrom
Open
fix: remove export kernel settings schema json#47echarles wants to merge 1 commit intojupyterlite:mainfrom
echarles wants to merge 1 commit intojupyterlite:mainfrom
Conversation
Contributor
Author
Member
You mean in a downstream repo reusing the extension, but without webpack? |
Author
|
it is failing while loading the node_modules while building with tsc. I am still trying to see why this is happening, and won't be able to link to a reproducer easily. Is that reexport needed? |
911432
suggested changes
Jun 21, 2024
There was a problem hiding this comment.
It refers to this site.
I would like to change it like this:
export { default as KERNEL_SETTINGS_SCHEMA } from '../schema/kernel.v0.schema.json';But I can fixed this about this[https://github.com/jupyterlite/pyodide-kernel/blob/0.3.x/packages/pyodide-kernel/scripts/generate-wheels-js.py#L80].
"export { default as allJSONUrl } from '../pypi/all.json';",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
which does not seem to be needed and fails downstream repos building with the error
...and cannot be used with 'export *'..