You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to the discussion pyodide/pyodide#3573 by @bollwyvl once we have the ability to create a custom pyodide-lock.json we need to have some way to point this kernel to use it.
Supposing this pyodide-lock.json is created alongside other JupyterLite files and deployed with those, I'm also not sure how that URL should look like: just a relative path?
Though looking at #29@bollwyvl are you saying that {lite_dir}/pypi/repodata.json (now {lite_dir}/pypi/pyodide-lock.json) would be a hardcoded path, and that this configurability is not needed? Either way should be fine.
In which case I can close this.
**Edit:**also, do I also need to add it to packages/pyodide-kernel-extension/schema/kernel.v0.schema.json to avoid?
error TS2741: Property 'pyodideLockFileURL' is missing in type '{ baseUrl: string; pyodideUrl: string; indexUrl: string;
pipliteWheelUrl: string; pipliteUrls: string[]; disablePyPIFallback: boolean; location: string; mountDrive: boolean; }' but required in type 'IOptions'.
As of #103, pyodideLockURL (and JSON-compatible friends in loadPyodide(options)) are now available to be configured in jupyter-lite.json, which should ship as part of jupyterlite-pyodide-kernel 0.3.0.
Minor upstream note: moving the options typing into a named interface would make this just that much better for downstreams! I didn't fully grok the ts-in-js toolchain to make that happen, however...
Looking further down the line, these options should put enough pieces in place to support an addon that:
uses e.g. a browser to do a real solve of the lock from micropip.freeze
grabs all the wheels
backfills the import names with pyodide-lock
I had started them in the same PR, but it became clear that this would add rather a lot of complexity, so will probably try to land it as another installable package, but theoretically could become an [lock] extra of this package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the discussion pyodide/pyodide#3573 by @bollwyvl once we have the ability to create a custom
pyodide-lock.jsonwe need to have some way to point this kernel to use it.Supposing this
pyodide-lock.jsonis created alongside other JupyterLite files and deployed with those, I'm also not sure how that URL should look like: just a relative path?