-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(payment-methods): Add volatile payment method id support in proxy v2 #10597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prasunna09
wants to merge
52
commits into
main
Choose a base branch
from
temp-pm-id-support-in-proxy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+184
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perswitch into add-guest-checkout-api-changes
…perswitch into add-guest-checkout-api-changes
…perswitch into add-guest-checkout-api-changes
…perswitch into add-guest-checkout-api-changes
…switch into guest-checkout-core-changes
…switch into guest-checkout-core-changes
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10597 +/- ##
=======================================
Coverage ? 6.38%
=======================================
Files ? 1268
Lines ? 318754
Branches ? 0
=======================================
Hits ? 20358
Misses ? 298396
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…switch into temp-pm-id-support-in-proxy
ShankarSinghC
previously approved these changes
Dec 15, 2025
Sakilmostak
previously approved these changes
Dec 16, 2025
The base branch was changed.
ShankarSinghC
previously approved these changes
Dec 22, 2025
Sakilmostak
previously approved these changes
Dec 22, 2025
b7ae83f
…switch into temp-pm-id-support-in-proxy
…switch into temp-pm-id-support-in-proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add volatile payment method id support in proxy to fetch payment method object from Redis(volatile storage) and process the request.
this volatile payment method id is generate during guest checkout tokenization in payment method service.
changes made-
Additional Changes
Motivation and Context
How did you test it?
}'
curl --location 'http://localhost:8080/v2/proxy'
--header 'Content-Type: application/json'
--header 'Accept: application/json'
--header 'X-Profile-Id: pro_pKQdFzRh288nIJx2Wlsr'
--header 'Authorization: api-key=api key'
--data '{
"request_body": {
"source": {
"type": "card",
"number": "{{$card_number}}",
"expiry_month": "{{$card_exp_month}}",
"expiry_year": "{{$card_exp_year}}",
"billing_address": {
"address_line1": "123 High St.",
"address_line2": "Flat 456",
"city": "London",
"state": "GB",
"zip": "SW1A 1AA",
"country": "GB"
}
},
"processing_channel_id": "processing_channel_id",
"amount": 6540,
"currency": "USD",
"payment_type": "Regular",
"reference": "ORD-5023-4E89",
"description": "Set of 3 masks",
"capture": true,
"capture_on": "2019-09-10T10:11:12Z",
"billing_descriptor": {
"name": "Withdrawal",
"city": "London"
},
"shipping": {
"address": {
"address_line1": "Checkout.com",
"address_line2": "Flat 456",
"city": "London",
"state": "GB",
"zip": "SW1A 1AA",
"country": "GB"
},
"phone": {
"country_code": "+1",
"number": "415 555 2671"
}
}
},
"destination_url": "https://api.sandbox.checkout.com/payments",
"headers": {
"Content-Type": "application/json",
"Authorization": "api key"
},
"token": "12345_pm_019b659a23f77531af02232f9c4098b9",
"token_type": "volatile_payment_method_id",
"method": "POST"
}'