-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(payment-methods): add modular customer pml transformer #11064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GauravRawat369
wants to merge
20
commits into
10959-feature-add-query-params-in-pm-client
Choose a base branch
from
customer-pml-transformer
base: 10959-feature-add-query-params-in-pm-client
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(payment-methods): add modular customer pml transformer #11064
GauravRawat369
wants to merge
20
commits into
10959-feature-add-query-params-in-pm-client
from
customer-pml-transformer
+261
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ular-payment-method-client-wrapper
…59-feature-add-query-params-in-pm-client
Changed Files
|
ShankarSinghC
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This pull request introduces support for listing customer payment methods via a new microservice flow, and refactors the microservice interface to add robust handling of query and path parameters. It also updates the
ClientOperationtrait and related macros to better distinguish between V1 and V2 request types, and adds new types and request/response models to support the new functionality.Microservice interface improvements:
query_paramsmethod to theClientOperationtrait, allowing operations to specify query parameters for requests. Thepath_paramsmethod now explicitly takes a V1 request, and both methods have improved documentation and examples.impl_microservice_flow!macro to support the newquery_paramsmethod, and to ensure path and query parameter methods use the correct V1 request type. [1] [2]TransformedRequestand related logic to store both the V1 and V2 request payloads, and to use the V1 request for extracting path and query parameters when building the request URL. [1] [2] [3] [4]New feature: List customer payment methods flow:
listmodule and corresponding V1 request/response types for listing customer payment methods, including logic to extract path and query parameters from the request and transform the modular service response to the V1 API model. [1] [2] [3]v1feature flag.Refactoring and consistency:
Other changes:
timecrate as a dependency for handling date/time fields in new types.These changes collectively improve the flexibility and maintainability of the microservice interface, and add a new capability for listing customer payment methods via the V1 API.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy