feat(core): diesel models and db interface changes for call_back_mapper table #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
hyperswitch-bot
bot
added
the
M-database-changes
…witch into add-call-back-mapper-table
jarnura
previously approved these changes
Nov 14, 2024
| pub id: String, | ||
| #[serde(rename = "type")] | ||
| pub type_: String, | ||
| pub data: serde_json::Value, |
There was a problem hiding this comment.
Suggested change
| pub data: serde_json::Value, | |
| pub data: pii::SecretSerdeValue, |
There was a problem hiding this comment.
if there is no sensitive value, is this still needed? Also this table should be used for storing HS entity reference
| }; | ||
|
|
||
| #[async_trait::async_trait] | ||
| pub trait CallBackMapperInterface { |
There was a problem hiding this comment.
Can we please move the trait CallBackMapperInterface to hyperswitch_domain_models and have the domain models defined for CallBackMapper?
There was a problem hiding this comment.
this is a db interface, could you please tell me why db interface needs to be moved to domain model?
ps. checked all other db interface, no interface lies in domain model. please let me know If I m missing something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Created call_back_mapper table and implemented interface for DB operations.
this is added for network tokenization webhooks feature. Since this is generic, any kind of data (excluding sensitive info) can be stored.
db changes -
Network tokenization webhook feature use case - no merchant id is passed from token requestor, so network_token_requestor_ref_id is stored in this table along with merchant_id
Additional Changes
Motivation and Context
How did you test it?
This PR is only meant for creating new call_back_mapper table and doesn't interfere with any existing flows.
Checklist
cargo +nightly fmt --allcargo clippy