Fix not found error when running on windows#604
Open
saadshahd wants to merge 1 commit intojustadudewhohacks:masterfrom
Open
Fix not found error when running on windows#604saadshahd wants to merge 1 commit intojustadudewhohacks:masterfrom
saadshahd wants to merge 1 commit intojustadudewhohacks:masterfrom
Conversation
`process.env.path` will always be `true` which will make the flag `isElectronWebpack` always `false`
Author
|
actually, it didn't fix the issue, I had to install |
Owner
I think we need a better solution to detect, whether the module is bundled with webpack then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process.env.pathwill always betruewhich will make the flagisElectronWebpackalwaysfalse