Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 17 #64

Merged
merged 20 commits into from
Feb 9, 2024
Merged

Upgrade to Angular 17 #64

merged 20 commits into from
Feb 9, 2024

Conversation

justindujardin
Copy link
Owner

@justindujardin justindujardin commented Feb 9, 2024

  • Update Angular to 17.x
  • Update ngrx/* to 17.x
  • Update Storybook to 7.x
  • Remove spam license in source files
  • Remove flex-layout library usage

✖ Migration failed: Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.
  See "/tmp/ng-Qfcq7h/angular-errors.log" for further details.
 - update custom builder, remove flex-layout
 - needs fixing up the mat-mdc changes probably and theme changes. I'll do it next.
 - the LICENSE file is sufficient
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (7e87ef7) 68.45% compared to head (b1a3ad8) 68.68%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/app/models/combat/combat.effects.ts 78.18% 10 Missing and 2 partials ⚠️
src/app/models/game-state/game-state.effects.ts 66.66% 10 Missing and 1 partial ⚠️
...pp/components/player-card/player-card.component.ts 0.00% 2 Missing ⚠️
src/app/routes/game/game.resolver.ts 33.33% 2 Missing ⚠️
src/app/routes/world/world.component.ts 0.00% 2 Missing ⚠️
src/app/behaviors/collision.behavior.ts 0.00% 1 Missing ⚠️
.../app/components/debug-menu/debug-menu.component.ts 0.00% 1 Missing ⚠️
...nents/party-inventory/party-inventory.component.ts 0.00% 1 Missing ⚠️
.../app/components/party-menu/party-menu.component.ts 0.00% 1 Missing ⚠️
src/app/models/game-state/game-state.service.ts 66.66% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   68.45%   68.68%   +0.23%     
==========================================
  Files         165      165              
  Lines        5364     5391      +27     
  Branches      866      868       +2     
==========================================
+ Hits         3672     3703      +31     
+ Misses       1563     1558       -5     
- Partials      129      130       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justindujardin justindujardin marked this pull request as ready for review February 9, 2024 22:52
@justindujardin justindujardin merged commit d3c2dc2 into main Feb 9, 2024
8 checks passed
@justindujardin justindujardin deleted the feat/angular-upgrade branch February 9, 2024 22:52
Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 0.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant