forked from savonrb/savon
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update local savon #1
Open
X-sam
wants to merge
34
commits into
justworkshr:master
Choose a base branch
from
savonrb:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog entries for next release, which will be 2.13.0
* feat: Preventing "xmlns:xmlns" namespace but allowing "xmlns" namespace * test: Adding test for the envelope namespaces * refactor: Refactoring the namespaces on the specs
Documenting my current workflow to create a release.
* rename Savon::Response#hash to Savon::Response#full_hash * fix tests so they pass in both rack 2 and rack 3
Note String#snakecase is no longer monkey patched
Co-authored-by: Nathan Samson <[email protected]>
Note the change to exclude xmlns
- requires wasabi < 5
When stringifying 3.0, the CI's YAML engine would create the string "3" rather than "3.0". Turning this specific value into a String avoids this display difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring us up to date with chages upstream.