Remove kubelet-config stack after deprecation in 1.26 #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
force-pushed
the
remove-kubeletconfig-component
branch
from
c2e004d
to
3e93185
Compare
juanluisvaladas
requested changes
Jan 8, 2024
inttest/ap-ha3x3/ha3x3_test.go
Outdated
| if s.Len(plan.Status.Commands, 1) { | ||
| cmd := plan.Status.Commands[0] | ||
| s.Equal(appc.PlanCompleted, cmd.State) | ||
| s.Equal(appc.PlanCompleted, cmd.State) |
There was a problem hiding this comment.
This line is duplicated, it doesn't have any real impact so it's a nit, but let's remove it anyway.
The kubelet-config component has been deprecated in 1.26. Remove the corresponding resources from the cluster in 1.29. Rename all manifest files in the stack's folder to something that won't be picked up by the stack applier. Leave a note about the stack removal in the stack's folder. Signed-off-by: Tom Wieczorek <[email protected]>
twz123
force-pushed
the
remove-kubeletconfig-component
branch
from
3e93185
to
412b3c6
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The kubelet-config component has been deprecated in 1.26. Remove the corresponding resources from the cluster in 1.29. Rename all manifest files in the stack's folder to something that won't be picked up by the stack applier. Leave a note about the stack removal in the stack's folder.
Type of change
How Has This Been Tested?
Checklist: