Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate k0sctl version setting across test suites #3908

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

kke
Copy link
Contributor

@kke kke commented Jan 10, 2024

Description

Removes the need to make manual changes for k0sctl version bumps. The version is obtained from hack/tool/go.mod which is updated automatically by dependabot. All the other suites that use k0sctl now get their k0sctl version by reading it from hack/tool/go.mod.

The change to docs/nllb.md in previous bumps is omitted here - the version number there is cosmetic.

This should make a dependabot PR like #3906 be enough for bumping the k0sctl dependency.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@kke kke added enhancement New feature or request area/ci github_actions Pull requests that update GitHub Actions code labels Jan 10, 2024
@kke kke requested a review from a team as a code owner January 10, 2024 08:17
@kke kke requested review from ncopa and makhov January 10, 2024 08:17
Removes the need to make manual changes for k0sctl version bumps.
The version is obtained from hack/tool/go.mod which is updated
automatically by dependabot. All the other suites that use k0sctl
now get their k0sctl version by reading it from hack/tool/go.mod.

Signed-off-by: Kimmo Lehto <[email protected]>
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to trigger the ostests before merging any automatic version bumps. This might get forgotten if it's not obvious that the go.mod version change in hack/tool changes the k0sctl version in the ostests and network tests. Moreover, I think we have a quite outdated k0sctl version in the release e2e tests. (But maybe that is better addressed by replacing those with a workflow call to the ostests.)

.github/workflows/ostests-e2e.yaml Outdated Show resolved Hide resolved
@kke kke requested a review from twz123 January 10, 2024 11:30
@twz123 twz123 merged commit e1d0979 into main Jan 16, 2024
72 checks passed
@twz123 twz123 deleted the simpler-k0sctl-bumps branch January 16, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants