-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use actions/setup-go@v5 in github actions #3914
Conversation
Maybe better use |
I think we're manually caching just the docker-builder deps like: - name: Cache GOMODCACHE
uses: actions/cache@v3
with:
key: unittests-k0s-linux-amd64-gomodcache-${{ hashFiles('go.sum') }}
restore-keys: |
build-k0s-linux-amd64-gomodcache-${{ hashFiles('go.sum') }}
path: |
build/cache/go/mod There was one which cached We could of course stop using setup-go altogether and just run everything through the builder. |
with: | ||
go-version: ${{ env.GO_VERSION }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was GO_VERSION ever required for something else than this? If not, it could be removed from .github/workflows/prepare-build-env.sh
.
This pull request has merge conflicts that need to be resolved. |
This pull request has merge conflicts that need to be resolved. |
This pull request has merge conflicts that need to be resolved. |
Signed-off-by: Kimmo Lehto <[email protected]>
The PR is marked as stale since no activity has been recorded in 30 days |
The PR is marked as stale since no activity has been recorded in 30 days |
The PR is marked as stale since no activity has been recorded in 30 days |
Description
Use actions/setup-go@v5 instead of v3.
Closes #3795
Type of change
How Has This Been Tested?
Checklist: