Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actions/setup-go@v5 in github actions #3914

Closed
wants to merge 1 commit into from
Closed

Use actions/setup-go@v5 in github actions #3914

wants to merge 1 commit into from

Conversation

kke
Copy link
Contributor

@kke kke commented Jan 10, 2024

Description

Use actions/setup-go@v5 instead of v3.

Closes #3795

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@kke kke added area/ci github_actions Pull requests that update GitHub Actions code labels Jan 10, 2024
@twz123
Copy link
Member

twz123 commented Jan 10, 2024

Maybe better use with: {cache: false} for now? We'd need to inspect our own caching and replace that. Since there's actions/cache/save and actions/cache/restore available nowadays, there might be some potential to completely rework this.

@kke
Copy link
Contributor Author

kke commented Jan 10, 2024

I think we're manually caching just the docker-builder deps like:

      - name: Cache GOMODCACHE
        uses: actions/cache@v3
        with:
          key: unittests-k0s-linux-amd64-gomodcache-${{ hashFiles('go.sum') }}
          restore-keys: |
            build-k0s-linux-amd64-gomodcache-${{ hashFiles('go.sum') }}
          path: |
            build/cache/go/mod

There was one which cached ~/go/pkg/mod which I now removed.

We could of course stop using setup-go altogether and just run everything through the builder.

@kke kke marked this pull request as ready for review January 11, 2024 08:30
@kke kke requested a review from a team as a code owner January 11, 2024 08:30
@kke kke requested review from twz123 and jnummelin January 11, 2024 08:30
.github/workflows/check-network.yaml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Show resolved Hide resolved
.github/workflows/go.yml Show resolved Hide resolved
with:
go-version: ${{ env.GO_VERSION }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was GO_VERSION ever required for something else than this? If not, it could be removed from .github/workflows/prepare-build-env.sh.

.github/workflows/go.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
hack/tools/gen-matrix.sh Outdated Show resolved Hide resolved
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

Signed-off-by: Kimmo Lehto <[email protected]>
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Feb 18, 2024
@github-actions github-actions bot removed the Stale label Feb 19, 2024
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Mar 20, 2024
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Apr 20, 2024
@github-actions github-actions bot closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci github_actions Pull requests that update GitHub Actions code Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants