Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upload/download to share airgap bundles between tests #3927

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 12, 2024

Description

This removes the cache hack that was used to share the prebuilt image bundles with the integration tests. The upload/download action is now reasonably fast.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

This removes the cache hack that was used to share the prebuilt image
bundles with the integration tests. The upload/download action is now
reasonably fast.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review January 16, 2024 07:57
@twz123 twz123 requested a review from a team as a code owner January 16, 2024 07:57
@twz123 twz123 requested review from kke and makhov January 16, 2024 07:57
@twz123 twz123 merged commit 5a8fb82 into k0sproject:main Jan 16, 2024
77 checks passed
@twz123 twz123 deleted the airgap-bundle-upload branch January 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants