Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config docs for kube-proxy nftables mode #5038

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Add config docs for kube-proxy nftables mode #5038

merged 1 commit into from
Sep 27, 2024

Conversation

jnummelin
Copy link
Member

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jnummelin jnummelin requested a review from a team as a code owner September 25, 2024 13:05
@jnummelin jnummelin mentioned this pull request Sep 25, 2024
Closed
@jnummelin jnummelin added this to the 1.31 milestone Sep 25, 2024
twz123
twz123 previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace in the Markdown table could be adjusted 🙈

@jnummelin
Copy link
Member Author

Adjusted the table, @twz123 PTAL again (force pushed so need new review)

@jnummelin jnummelin merged commit b483a1a into k0sproject:main Sep 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twz123 twz123 twz123 approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
2 participants
@jnummelin @twz123