Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to compile CPLB on darwin #5185

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Don't try to compile CPLB on darwin #5185

merged 1 commit into from
Nov 18, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Nov 7, 2024

Description

The unix build tag includes darwin, but CPLB only compiles on Linux. Use the linux build tag for the implementation instead, and use the current windows stub for anything that isn't linux.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Nov 7, 2024
@twz123 twz123 marked this pull request as ready for review November 8, 2024 07:02
@twz123 twz123 requested review from a team as code owners November 8, 2024 07:02
@twz123 twz123 requested review from ncopa and kke November 8, 2024 07:02
@twz123 twz123 enabled auto-merge November 8, 2024 07:03
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123
Don't try to compile CPLB on darwin
1cfc8ff 
The unix build tag includes darwin, but CPLB only compiles on Linux. Use
the linux build tag for the implementation instead, and use the current
windows stub for anything that isn't linux.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 merged commit f7f153f into k0sproject:main Nov 18, 2024
90 checks passed
@twz123 twz123 deleted the no-cplb-on-darwin branch November 18, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @jnummelin