[Backport release-1.30] Fix etcd peer URL to support ipv6 #5190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
IPv6 URL need to have brackets [] around the ipv6 to separate it from the port. Eg https://[xx:yy:zz]:2380 Fix this by using net/url's String() formatter. Signed-off-by: Natanael Copa <[email protected]> (cherry picked from commit 1469e0c)
twz123
force-pushed
the
backport-5181-to-release-1.30
branch
from
312a8c3
to
a15dd6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.30, triggered by a label in #5181.See #5180.