Make transit_gateway have_attachment work with names
#586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
commented
Mar 5, 2024
| atts = find_tgw_attachments_by_tgw_id(@id) | ||
| ret = atts.find_all { |att| att.transit_gateway_attachment_id == att_id } | ||
| ret.any? | ||
| atts = find_tgw_attachments_by_tgw_id(id) |
There was a problem hiding this comment.
Specific bugfix on this line changing @id to id as @id wasn't initialised if should exist hadn't been called first.
With this change, it is now possible to check transit gateways have attachments based on the attachment name instead of just id. The name can either be a string or a regex. `have_attachment` now also works if `should exist` hasn't been called first (where `@id` wasn't initialised).
alexjfisher
force-pushed
the
transit_gateway_attachments
branch
from
cf4ac12
to
2b5f1b7
Compare
|
@alexjfisher Thank you!!! I am very sorry for the delay in merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it is now possible to check transit gateways have attachments based on the attachment name instead of just id. The name can either be a string or a regex.
have_attachmentnow also works ifshould existhasn't been called first (where@idwasn't initialised).