Avoid handling mac duplication during deletion #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Eoghan1232, @SchSeba, PTAL |
mlguerrero12
force-pushed
the
removehandleduplicatemacs
branch
3 times, most recently
from
c92fbb2 to
b2bbd8d
Compare
The bond-cni should not attempt to modify the mac addresses of slaves during deletion of the bond interface. The bond driver takes care of reverting any modifications. Only balance-tlb and balance-alb do not support slaves with same mac addresses. The plugin now handles mac duplicates only for these modes. Signed-off-by: Marcelo Guerrero <[email protected]>
mlguerrero12
force-pushed
the
removehandleduplicatemacs
branch
from
b2bbd8d to
a10ffb1
Compare
mlguerrero12
changed the title
SchSeba
reviewed
May 27, 2025
| "github.com/vishvananda/netlink" | ||
| "github.com/vishvananda/netns" | ||
|
|
||
| "github.com/intel/bond-cni/bond/util" |
There was a problem hiding this comment.
just nice to have we should switch to project to github.com/k8snetworkplumbingwg/bond-cni
| var err error | ||
|
|
||
| bondMode := netlink.StringToBondMode(mode) | ||
| if bondMode == netlink.BOND_MODE_BALANCE_TLB || bondMode == netlink.BOND_MODE_BALANCE_ALB { |
There was a problem hiding this comment.
do we have a test to cover this new change that we handle mac duplication only for this two modes?
|
and can you please rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bond-cni should not attempt to modify the mac addresses of slaves during deletion of the bond interface.
The bond driver takes care of reverting any modifications.
Only balance-tlb and balance-alb do not support slaves with same mac addresses. The plugin now handles mac duplicates only for these modes.