e2e: Avoid checking the number of iptables file #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the number of files in `/var/lib/multi-networkpolicy/iptables/` brings to a number of test flakes in GitHub CI lanes. This flakes are not reproducible in local development environments, therefore they are likely due to a low resource system. Beside these checks can flake, the component under test behavior looks good from the assertion point of view, which is the meaningful part for the these tests. Remove any verification about the `/var/lib/multi-networkpolicy/iptables/` folder in e2e tests Signed-off-by: Andrea Panattoni <[email protected]>
Pull Request Test Coverage Report for Build 13436105054Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the number of files in
/var/lib/multi-networkpolicy/iptables/brings to a number of test flakes in GitHub CI lanes. This flakes are not reproducible in local development environments, therefore they are likely due to a low resource system.Beside these checks can flake, the component under test behavior looks good from the assertion point of view, which is the meaningful part for the these tests.
Remove any verification about the
/var/lib/multi-networkpolicy/iptables/folder in e2e tests