-
Notifications
You must be signed in to change notification settings - Fork 10
Add support for avatar rewards ( + fix date overlapping with title) #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include screenshots/pasted HTML from the popup notifications before and after this fix? Also, could you check if these notifications have content values or not in the API request the extension sends? That'll give me more context.
Oh, you're completely correct; I forgot to test this without the extension. It's missing a lot from the notifications API. |
I'll see about getting my local extension running again and testing your fix, and possibly adding my own. I'll probably be on the KAE Discord tomorrow if you want to talk details there. Thanks for contributing! |
There is a small issue; Lets take the Hopper reward notification shown in the original post. But using Instead, using either the KAID or username will work. Unfortunately I cannot seem to use |
EDIT: Nevermind; I worked out what was causing the error. The redirect link is fixed now. |
Very cool! I won't be on Discord today after all, got busy, but likely will tomorrow, and will see about testing this change then. |
No problem! I would not be available anyway as Europe is 6-8 hours ahead of Central Time. |
It seems not. Here are the API entries for the notifications that I have shown in the original post: |
@An0n3m0us Looks good to me. It'd probably be easier if I merge this before #211, then you update that branch accordingly. Sound good? |
Closes #200
me
instead ofKAID
orusername
which interrupts redirect)