Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration: Fix Hash ordering from StableEncoding #271

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

jmcardon
Copy link
Member

This PR fixes the ordering for StableEncoding outputs for PactValue objects, and adds a simple regression (hash (chain-data)), which passes in both prod and pact-5

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
    N/A
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

@jmcardon jmcardon merged commit 7f17548 into master Oct 24, 2024
13 checks passed
@jmcardon jmcardon deleted the jose/fix-stableencoding-ordering branch October 24, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant