Use sasl_auth:client_done/1 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasl_auth was updated to require an explicit destruction of a context in an effort to avoid in memory race conditions. This commit merely updates the two plugins to use this function.
starbelly
commented
Aug 24, 2024
starbelly
force-pushed
the
use-latest-sasl-auth
branch
2 times, most recently
from
da98bbc to
54bc8b0
Compare
starbelly
commented
Aug 24, 2024
| @@ -14,12 +14,12 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| otp: ['23', '24', '25'] | |||
| rebar3: ['3.16.1'] | |||
| otp: ['24', '25', '26', '27'] | |||
There was a problem hiding this comment.
Re-adding comment, we can still test 23, but IMHO we should drop it, and 24, though I left that.
starbelly
commented
Aug 24, 2024
| @@ -24,6 +24,10 @@ jobs: | |||
| with: | |||
| path: /tmp/.buildx-cache | |||
| key: ${{ runner.os }}-buildx-${{ hashFiles('./example/image/Dockerfile') }} | |||
| - name: Install docker-compose | |||
| run: | | |||
| curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose | |||
There was a problem hiding this comment.
docker-compose doesn't seemed to be install anymore (although a plugin is), looking it up on docker github, this was the solution.
starbelly
commented
Aug 24, 2024
| @@ -43,6 +43,8 @@ RUN curl -O https://raw.githubusercontent.com/kerl/kerl/master/kerl | |||
|
|
|||
| RUN chmod a+x kerl | |||
|
|
|||
| ENV KERL_BUILD_DOCS= | |||
There was a problem hiding this comment.
Makes build faster for end to end testing
starbelly
commented
Aug 24, 2024
| {rebar3_hex, "~> 7.0.1"}, | ||
| {rebar3_format, "~> 1.0.1"}, | ||
| {erlfmt, "~> 1.0.0"}, | ||
| {pc, "~> 1.15.0"}, |
There was a problem hiding this comment.
Updated all per testing OTP 27 now.
zmstone
reviewed
Aug 25, 2024
Co-authored-by: zmstone <[email protected]>
Co-authored-by: zmstone <[email protected]>
zmstone
reviewed
Aug 29, 2024
zmstone
approved these changes
Aug 29, 2024
|
published 0.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sasl_auth was updated to require an explicit destruction of a context in an effort to avoid in memory race conditions. This commit merely updates the two plugins to use this function.