Skip to content

Add default system prompts to base model wrapper classes #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nkaenzig wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add default system prompts to base model wrapper classes #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/eva/language/models/wrappers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,31 @@ class LanguageModel(base.BaseModel[TextBatch, List[str]]):
expected by the `model_forward` method.
"""

_default_system_prompt = (
"You are a helpful language assistant. "
"You are able to process the text content that the user provides,"
"and assist the user with a variety of tasks using natural language."
)

def __init__(
self, system_prompt: str | None, output_transforms: Callable | None = None
self, system_prompt: str | None = None, output_transforms: Callable | None = None
) -> None:
"""Creates a new model instance.

Args:
system_prompt: The system prompt to use for the model (optional).
system_prompt: The system prompt to use for the model. If set to None,
will use the default system prompt. If you don't want to use any
system prompt, you can set this to an empty string.
output_transforms: Optional transforms to apply to the output of
the model's forward pass.
"""
super().__init__(transforms=output_transforms)

self.system_message = ModelSystemMessage(content=system_prompt) if system_prompt else None
self.system_message = (
ModelSystemMessage(content=system_prompt or self._default_system_prompt)
if system_prompt != ""
else None
)

@override
def forward(self, batch: TextBatch) -> List[str]:
Expand Down
18 changes: 15 additions & 3 deletions src/eva/multimodal/models/wrappers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,31 @@ class VisionLanguageModel(base.BaseModel[TextImageBatch, List[str]]):
expected by the `model_forward` method.
"""

_default_system_prompt = (
"You are a helpful vision and language assistant. "
"You are able to understand the visual content that the user provides, "
"and assist the user with a variety of tasks using natural language."
)

def __init__(
self, system_prompt: str | None, output_transforms: Callable | None = None
self, system_prompt: str | None = None, output_transforms: Callable | None = None
) -> None:
"""Creates a new model instance.

Args:
system_prompt: The system prompt to use for the model (optional).
system_prompt: The system prompt to use for the model. If set to None,
will use the default system prompt. If you don't want to use any
system prompt, you can set this to an empty string.
output_transforms: Optional transforms to apply to the output of
the model's forward pass.
"""
super().__init__(transforms=output_transforms)

self.system_message = ModelSystemMessage(content=system_prompt) if system_prompt else None
self.system_message = (
ModelSystemMessage(content=system_prompt or self._default_system_prompt)
if system_prompt != ""
else None
)

@override
def forward(self, batch: TextImageBatch) -> List[str]:
Expand Down