Skip to content

Fix RO remount on UKI #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Fix RO remount on UKI #479

merged 1 commit into from
Jun 5, 2025

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Jun 5, 2025

Close the log file descriptors before remounting / RO otherwise it wont let us as we have open stuff on it

Close the log file descriptors before remounting / RO otherwise it wont
let us as we have open stuff on it

Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka requested review from a team and Copilot June 5, 2025 13:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fix root filesystem remount to read-only by closing and reinitializing the logger, adjust DAG logging timing, and add an init fallback path.

  • Close the logger before remounting / as read-only and reinitialize it afterward
  • Move DAG print call and warn about init execution with a /bin/init fallback
  • Bump dependencies in go.mod

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pkg/state/steps_uki.go Close/reopen logger around remount, relocate DAG logging, add fallback for init
go.mod Bump ghw to v0.17.0, kairos-sdk to v0.9.4, and yip to v1.16.2
Comments suppressed due to low confidence (1)

pkg/state/steps_uki.go:502

  • This prints the DAG unconditionally, including on successful remounts; consider moving it into the error branch so it only logs when you actually drop to the emergency shell.
internalUtils.KLog.Logger.Info().Msg(s.WriteDAG(g))

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 11.98%. Comparing base (707f602) to head (510951a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/state/steps_uki.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   12.03%   11.98%   -0.06%     
==========================================
  Files          11       11              
  Lines        1819     1828       +9     
==========================================
  Hits          219      219              
- Misses       1583     1592       +9     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Itxaka Itxaka merged commit 538a225 into main Jun 5, 2025
12 checks passed
@Itxaka Itxaka deleted the fix_RO_remount_uki branch June 5, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant