Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src] Modified mel computations (cleaned up version) #3165

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

danpovey
Copy link
Contributor

to be tested. Would be activated by setting
modified=true
in conf/mfcc_hires.conf

@RuABraun
Copy link
Contributor

This is supposed to give a small but consistent performance improvement correct?

@danpovey
Copy link
Contributor Author

danpovey commented Mar 25, 2019 via email

@danpovey
Copy link
Contributor Author

danpovey commented Mar 25, 2019 via email

@RuABraun
Copy link
Contributor

I could do a build on my own data (so you'd have to take my word for the results), if that works for you?

@danpovey
Copy link
Contributor Author

danpovey commented Mar 26, 2019 via email

high_freq_ : center_freqs_(bin + 1));

BaseFloat d1 = (next_center - center_freq) * 1.1,
d2 = 60.0 + 50.0 * (center_freq / (center_freq + 700.0));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be breakpoint_ instead of 700.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of making this a separate issue from the breakpoint, so that when we tune it it doesn't have to have the same value. Can you compare 700 with 300 (our current breakpoitn) in your new experiments? If 300 works better we can reconsider.

@RuABraun
Copy link
Contributor

RuABraun commented Jun 2, 2019

Sorry about the delay on this:

Some info about the model: 100h with 13 layer tdnnf. No ivector. Decoding with a 1M ngram language model (no rescoring).

Because of how my data is acquired, I cannot always guarantee that there is no overlap in speakers between training/test, these are the test sets A, B, C. Some test sets I can guarantee it, those are X, Y, Z

X Y Z A B C
baseline 18.01 17.57 29.12 19.57 12.03 23.82
modified 18.70 17.85 29.56 19.48 12.02 23.59

As can see from the results it seems the modified version overfits more.

@danpovey
Copy link
Contributor Author

danpovey commented Jun 2, 2019

Great, thanks. It turns out there may have been a problem with that particular code (i.e. there was a mismatch to what it should have been), although I don't know how important that actually was.
Hopefully at some point in the future I will have a fixed version.

@stale
Copy link

stale bot commented Jun 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale bot on the loose label Jun 19, 2020
@stale
Copy link

stale bot commented Jul 19, 2020

This issue has been automatically closed by a bot strictly because of inactivity. This does not mean that we think that this issue is not important! If you believe it has been closed hastily, add a comment to the issue and mention @kkm000, and I'll gladly reopen it.

@stale stale bot closed this Jul 19, 2020
@kkm000 kkm000 reopened this Jul 19, 2020
@stale stale bot removed the stale Stale bot on the loose label Jul 19, 2020
@stale
Copy link

stale bot commented Sep 17, 2020

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.

@stale stale bot added the stale Stale bot on the loose label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale bot on the loose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants