AMI hotfix #4739
Draft
AMI hotfix #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f this is the default
danpovey
reviewed
May 9, 2022
|
Oops! Yup, I meant to only push a subset of the changes here. (It was packaged in this state for the course I did this project for). Let's delete this PR and I'll make a new one later this week with just the relevant fixes. |
|
yes, please provide just the relevant fixes. Thank you!
y.
…On Mon, May 9, 2022 at 7:53 AM Alex Thornton ***@***.***> wrote:
Oops! Yup, I meant to only push a subset of the changes here. (It was
packaged in this state for the course I did this project for). Let's delete
this PR and I'll make a new one later this week with just the relevant
fixes.
—
Reply to this email directly, view it on GitHub
<#4739 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUKYXYNGODBDDBNJHAD3QLVJD4DBANCNFSM5VMQUQ4Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open. |
kkm000
added
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a couple issues with egs/ami (broken URLs, missing call to generate x-vector, etc). As part of a class at Columbia University, I worked out of that directory and cleaned up some of those dependencies. The corrections should become part of egs/ami for posterity.