Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/extra_checks/checks/model_field_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,9 @@ def apply(
):
return
check = f'models.Q({in_name}=[{", ".join([self._repr_choice(c) for c in field_choices])}])'
arg_name = "condition" if django.VERSION >= (5, 1) else "check"
yield self.message(
"Field with choices must have companion CheckConstraint to enforce choices on database level.",
hint=f'Add to Meta.constraints: `models.CheckConstraint(name="%(app_label)s_%(class)s_{field.name}_valid", check={check})`',
hint=f'Add to Meta.constraints: `models.CheckConstraint(name="%(app_label)s_%(class)s_{field.name}_valid", {arg_name}={check})`',
obj=field,
)
12 changes: 7 additions & 5 deletions tests/test_model_field_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,16 +241,18 @@ def test_field_choices_constraint(test_case):
"blank_included",
"integer_blank_invalid",
}
assert 'check=models.Q(partial__in=["S", "C"]))' in errors["partial"].hint
assert "check=models.Q(missed__in=[1, 2]))" in errors["missed"].hint
arg_name = "condition" if django.VERSION >= (5, 1) else "check"
assert f'{arg_name}=models.Q(partial__in=["S", "C"]))' in errors["partial"].hint
assert f"{arg_name}=models.Q(missed__in=[1, 2]))" in errors["missed"].hint
assert (
'check=models.Q(blank_missed__in=["A", "B", ""])' in errors["blank_missed"].hint
f'{arg_name}=models.Q(blank_missed__in=["A", "B", ""])'
in errors["blank_missed"].hint
)
assert (
'check=models.Q(blank_included__in=["A", "B", ""])'
f'{arg_name}=models.Q(blank_included__in=["A", "B", ""])'
in errors["blank_included"].hint
)
assert (
"check=models.Q(integer_blank_invalid__in=[1, 2])"
f"{arg_name}=models.Q(integer_blank_invalid__in=[1, 2])"
in errors["integer_blank_invalid"].hint
)
Loading