Skip to content

Fix: do not access CheckConstraint.check on django >=5.1 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix: do not access CheckConstraint.check on django >=5.1 #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7414cf6
Fix: do not access `CheckConstraint.check` on django >=5.1
sobolevn Dec 9, 2024
bf7d659
Fix lint
sobolevn Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/extra_checks/checks/model_field_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,15 @@ def apply(
field_choices.append("")
in_name = f"{field.name}__in"
for constraint in model._meta.constraints:
if isinstance(constraint, models.CheckConstraint) and isinstance(
constraint.check, models.Q
):
for entry in constraint.check.children:
if isinstance(constraint, models.CheckConstraint):
condition = (
constraint.check
if django.VERSION < (5, 1)
else constraint.condition
)
if not isinstance(condition, models.Q):
continue
for entry in condition.children:
if (
isinstance(entry, tuple)
and entry[0] == in_name
Expand Down
Loading