Skip to content

remove unused zlib dependency #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jelhan
Copy link

@jelhan jelhan commented Mar 31, 2025

The zlib dependency is not needed anymore. It was refactored out of the code long time ago. But missed to be removed from the list of dependencies.

At the same time it caused the installation of the NPM package to fail in consuming apps in some cases:

npm error code 127
npm error path /home/main/Code/open-source/croodle/node_modules/zlib
npm error command failed
npm error command sh -c node-waf clean || true; node-waf configure build
npm error sh: 1: node-waf: not found

This is a result of the package being very old. It was released in 2011. The build infrastructure it relies on was deprecated long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant