Skip to content

Commit

Permalink
add comments for issue #147
Browse files Browse the repository at this point in the history
  • Loading branch information
gggeek committed Dec 2, 2017
1 parent c05a174 commit 9099e0a
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Core/FieldHandler/EzBinaryFile.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function hashToFieldValue($fieldValue, array $context = array())
* @param array $context
* @return array
*
* @todo check out if this works in ezplatform
* @todo check if this works in ezplatform
*/
public function fieldValueToHash($fieldValue, array $context = array())
{
Expand Down
1 change: 1 addition & 0 deletions Resources/doc/DSL/Contents.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
alt_text: xyz # Optional, only used for images
filename: abc # Optional, taken from the actual file if not specified
mime_type: def # Optional. For ezbinaryfile and ezmedia only. If not specified, the actual file is analyzed using the php function mime_content_type()
# NB: this seems to work only with eZPublish < 5.4 / 2014.11; see bug https://github.com/kaliop-uk/ezmigrationbundle/issues/147
has_controller: false # Optional. For ezmedia only
autoplay: false # Optional. For ezmedia only
loop: false # Optional. For ezmedia only
Expand Down
14 changes: 13 additions & 1 deletion Tests/dsl/good/UnitTestOK004_content.yml
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@
- ezbinaryfile:
path: emptyfile.txt
filename: lol2.txt
mime_type: something
mime_type: something/else
- ezmedia:
path: small.flv
filename: lol3.flv
Expand All @@ -340,6 +340,18 @@
destinationContentId: 'reference:kmb_test_004_1'
- ezobjectrelationlist:
destinationContentIds: [ 'reference:kmb_test_004_1', 'reference:kmb_test_004_2' ]
references:
-
identifier: kmb_test_004_10_mimetype
attribute: attributes.ezbinaryfile.mimeType

# Currently fails... See: https://github.com/kaliop-uk/ezmigrationbundle/issues/147
#-
# type: assert
# target: reference
# identifier: reference:kmb_test_004_10_mimetype
# test:
# equals: something/else

-
type: content
Expand Down

0 comments on commit 9099e0a

Please sign in to comment.