Skip to content

drop Play 2.7 and test on Play 2.8, 2.9, and 3.0 #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

ivantopo
Copy link
Contributor

@ivantopo ivantopo commented Jun 4, 2025

This change starts testing the Play instrumentation in Play 2.9 and 3.0 and drops 2.7. The instrumentation didn't change at all so it will continue to work in Play 2.7 but we are not going to be testing older versions anymore.

There is one tiny disparity on how the instrumentation works with Pekko vs Akka: the component tag for metrics and spans will be pekko.http.server instead of play.server.pekko-http because we would need to do a more significant effort in refactoring the tests and possibly the build and that effort doesn't seem to be worth it. Technically speaking it is still correct information because after all, the HTTP server IS Pekko HTTP, but just by looking at the metrics/spans you wouldn't know that this is actually Play Framework using Pekko HTTP instead of using Pekko HTTP directly.

@ivantopo ivantopo force-pushed the tests-for-play-2-7-and-3 branch from a268bac to ac3a955 Compare June 5, 2025 08:36
@ivantopo ivantopo merged commit a6dd3c3 into kamon-io:master Jun 8, 2025
2 checks passed
@ivantopo ivantopo deleted the tests-for-play-2-7-and-3 branch June 8, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant