drop Play 2.7 and test on Play 2.8, 2.9, and 3.0 #1400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change starts testing the Play instrumentation in Play 2.9 and 3.0 and drops 2.7. The instrumentation didn't change at all so it will continue to work in Play 2.7 but we are not going to be testing older versions anymore.
There is one tiny disparity on how the instrumentation works with Pekko vs Akka: the
component
tag for metrics and spans will bepekko.http.server
instead ofplay.server.pekko-http
because we would need to do a more significant effort in refactoring the tests and possibly the build and that effort doesn't seem to be worth it. Technically speaking it is still correct information because after all, the HTTP server IS Pekko HTTP, but just by looking at the metrics/spans you wouldn't know that this is actually Play Framework using Pekko HTTP instead of using Pekko HTTP directly.