c.2: improve performance #724
Merged
+432
−510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves speed (~15% on the perf test). MalType must drop the const modifier. Then, atoms can be slightly simplified.
Various typos or space formatting. Remove the gprof output file when cleaning. Prefer unsigned types when negative values do not make sense. Prefer bool to int. Do not assert that a pointer is not NULL right before dereferencing it. Fix vector_append when the initial capacity is 0 (this does not happen yet). Check the count after filling a vector.
instead of repeated string comparisons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute hashes at most once.
Recognize forms with a hash instead of a sequence of string comparisons.