-
Notifications
You must be signed in to change notification settings - Fork 4
Fixed icon sources. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Windows - Completely redone. MacOS - Completely redone. Uses accurately shaped icons and has @2x's different square as well. Linux - Completely redone.
Hi there! Thanks a lot. However, I would like to know a bit more about your reasoning here:
Overall, I think the only real "fix" here is that the Windows icon now covers the entire icon, which is indeed a valid improvement. Or do you see this differently? |
Shoot, I didn't export them as optimized, that's why they're so big. |
128x128 because it might be better to make a rendered size for it rather than trust Windows to scale it down right, but that's just me. It's probably fine as is but it should be checked in Windows itself to see if it's better or worse than making a direct render for it. |
Yeah, I think the Windows fixes are good. But still: What's the difference between the macOS icons? |
|
||
convert \ | ||
"$WIN_TMP_DIR/16.png" \ | ||
"$WIN_TMP_DIR/32.png" \ | ||
"$WIN_TMP_DIR/48.png" \ | ||
"$WIN_TMP_DIR/64.png" \ | ||
"$WIN_TMP_DIR/96.png" \ | ||
"$WIN_TMP_DIR/128.png \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"$WIN_TMP_DIR/128.png \ | |
"$WIN_TMP_DIR/128.png" \ |
As discussed on Discord, I integrated most of your changes here: fbe783f. Thanks again for the fixes! |
Windows - Completely redone.
MacOS - Completely redone. Uses accurately shaped icons and has @2x's different square as well.
Linux - Completely redone.