Skip to content

Fixed icon sources. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fixed icon sources. #1

wants to merge 3 commits into from

Conversation

Bingies24
Copy link
Contributor

@Bingies24 Bingies24 commented Dec 24, 2024

Windows - Completely redone.
MacOS - Completely redone. Uses accurately shaped icons and has @2x's different square as well.
Linux - Completely redone.

Windows - Completely redone.
MacOS - Completely redone. Uses accurately shaped icons and has @2x's different square as well.
Linux - Completely redone.
@Schneegans
Copy link
Contributor

Schneegans commented Dec 24, 2024

Hi there! Thanks a lot. However, I would like to know a bit more about your reasoning here:

  • 128px Windows size? I guess we can add it; however it's optional and as it contains the same blossom, it really doesn't matter. If Windows downscales it from 256x256 it will be exactly the same result as it's a factor of two.
  • I think we do not need a different background for Windows and Linux. We can use the same SVG but use a different margin.
  • What's the difference between the macOS icons? I do not see any difference.
  • What did change in bg_tiny_square.svg?
  • All your SVGs contain way too much useless defs. They are all more than 200kB+ where less than 10kB should be sufficient. Just have a look at the diff, you almost added 20.000 lines!

Overall, I think the only real "fix" here is that the Windows icon now covers the entire icon, which is indeed a valid improvement. Or do you see this differently?

@Bingies24
Copy link
Contributor Author

Bingies24 commented Dec 25, 2024

Shoot, I didn't export them as optimized, that's why they're so big.
MacOS doesn't use a rounded square but a specific signature shape. I changed it to use that shape instead like it was pre-source split. bg_tiny_square.svg also uses the same square.
I just wanted Windows to not have to use margins for the base since it looked better in my opinion. What do you have in mind instead?

@Bingies24
Copy link
Contributor Author

128x128 because it might be better to make a rendered size for it rather than trust Windows to scale it down right, but that's just me. It's probably fine as is but it should be checked in Windows itself to see if it's better or worse than making a direct render for it.

@Schneegans
Copy link
Contributor

Yeah, I think the Windows fixes are good. But still: What's the difference between the macOS icons?


convert \
"$WIN_TMP_DIR/16.png" \
"$WIN_TMP_DIR/32.png" \
"$WIN_TMP_DIR/48.png" \
"$WIN_TMP_DIR/64.png" \
"$WIN_TMP_DIR/96.png" \
"$WIN_TMP_DIR/128.png \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"$WIN_TMP_DIR/128.png \
"$WIN_TMP_DIR/128.png" \

@Schneegans
Copy link
Contributor

As discussed on Discord, I integrated most of your changes here: fbe783f. Thanks again for the fixes!

@Schneegans Schneegans closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants