Skip to content

Add blossom_simple.svg for Simple Icons usage #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented Mar 29, 2025

This asset is based on the blossom_small.svg and is made for Simple Icons.

I've optimized the icon to single-path to meet Simple Icons' requirement.

I also tested this file with Simple Icons' linter. You can submit it directly to Simple Icons for addition.

According to the popularity requirement from Simple Icons, we need to wait until the main repository https://github.com/kando-menu/kando reaches 5,000 stars. But I believe it will not take so long.

Cheers!

Preview

Small




Tiny




@Schneegans
Copy link
Contributor

Thanks for looking into this! I have two thoughts here:

  • Might it be a better solution to clean up both blossom_small.svg and blossom_tiny.svg to meet the requirements instead of adding a new icon? It would also be fine to make it black, we would only need to adjust the script slightly to replace the colors the other way around. Like here.
  • For the small badges you posted above, I think the tiny variant would actually look better. The tiny variant has a bit more margin between the petals - with the small variant the petals start to merge at this scale which does not look that good, IMHO.

What do you think?

@LitoMore
Copy link
Contributor Author

Might it be a better solution to clean up both blossom_small.svg and blossom_tiny.svg to meet the requirements instead of adding a new icon?

You can probably keep them for future re-processing. The -simple.svg one means it's prepared for Simple Icons. We don't have to convert all other assets to Simple Icons' standard.

If you want to make these two assets into single-path for your project. I can process it for you. 😊

For the small badges you posted above, I think the tiny variant would actually look better. The tiny variant has a bit more margin between the petals - with the small variant the petals start to merge at this scale which does not look that good, IMHO.

Sounds good! It's up to you! ✌️

@LitoMore
Copy link
Contributor Author

@Schneegans Changed to tiny style!

@Schneegans
Copy link
Contributor

Yeah, I think the tiny variant looks better. But ultimately we can decide this once we reach 5k stars 😄

So I would suggest to turn both the tiny and small variant into black single-path icons and adapt the script accordingly. I think that's the cleanest approach.

@LitoMore
Copy link
Contributor Author

So I would suggest to turn both the tiny and small variant into black single-path icons and adapt the script accordingly. I think that's the cleanest approach.

Sure! Operation done!

@Schneegans
Copy link
Contributor

Do you want to look into adapting the script? I could also merge this to a temporary branch and tweak it on my end.

@LitoMore
Copy link
Contributor Author

I'm not good at shell scripts. I would like to learn how you deal with this. 👍

@Schneegans Schneegans changed the base branch from main to feature/simplify-icons March 30, 2025 04:27
@Schneegans Schneegans merged commit a936ca3 into kando-menu:feature/simplify-icons Mar 30, 2025
1 check passed
@LitoMore LitoMore deleted the add-simple-icon branch March 30, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants