Fix SPI initialization for libopencm3 update #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace rcc_periph_reset_pulse() with explicit hold/release sequence to restore display functionality after libopencm3 update. Fixes black screen issue on DPS5015 after recent libopencm3 changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes black screen issue caused by commit c52ebac which updated libopencm3 and changed SPI reset method.
Root Cause
Commit c52ebac replaced
spi_reset(SPI2)withrcc_periph_reset_pulse(RST_SPI2)during libopencm3 update. However,rcc_periph_reset_pulse()in newer libopencm3 doesn't properly complete the reset sequence, leaving SPI peripheral in undefined state and causing ILI9163C display controller initialization to fail.Fix
Replace
rcc_periph_reset_pulse(RST_SPI2)with explicit two-step reset:rcc_periph_reset_hold(RST_SPI2)- Assert resetrcc_periph_reset_release(RST_SPI2)- Release resetThis ensures proper reset timing and restores display functionality.
Testing
AI slop, but I tested it