ci: upgrade pnpm to 9.1.2

[warjiang]

What type of PR is this?
/kind bug

What this PR does / why we need it:
upgrade pnpm version otherwise pnpm will install latest dependencies instead of following the pnpm-lock file
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[warjiang]

/assign @RainbowMango

[RainbowMango]

Echo from https://github.com/karmada-io/dashboard/actions/runs/15388148918/job/43291266877:

Error: src/components/panel/index.tsx(67,38): error TS2322: Type 'MenuItem[]' is not assignable to type 'Partial<BreadcrumbItemType & BreadcrumbSeparatorType>[]'.
Type 'MenuItem' is not assignable to type 'Partial<BreadcrumbItemType & BreadcrumbSeparatorType>'.
Index signature for type 'data-${string}' is missing in type 'MenuItem'.
 ELIFECYCLE  Command failed with exit code 2.

What's the root cause of it?

upgrade pnpm version otherwise pnpm will install latest dependencies instead of following the pnpm-lock file

Do you mean [email protected] always installs the latest dependencies?

[warjiang]

Echo from https://github.com/karmada-io/dashboard/actions/runs/15388148918/job/43291266877:

Error: src/components/panel/index.tsx(67,38): error TS2322: Type 'MenuItem[]' is not assignable to type 'Partial<BreadcrumbItemType & BreadcrumbSeparatorType>[]'.
Type 'MenuItem' is not assignable to type 'Partial<BreadcrumbItemType & BreadcrumbSeparatorType>'.
Index signature for type 'data-${string}' is missing in type 'MenuItem'.
 ELIFECYCLE  Command failed with exit code 2.

What's the root cause of it?

upgrade pnpm version otherwise pnpm will install latest dependencies instead of following the pnpm-lock file

Do you mean [email protected] always installs the latest dependencies?

root cause is the mismatched version of pnpm(one in ci and the other one in pnpm-lock file)

pnpm-lock file has extra field to indicate the version of pnpm, in the main branch, the pnpm-lock file is generate by pnpm@9

dashboard/ui/pnpm-lock.yaml

Lines 1 to 5 in 185adbd

	lockfileVersion: '9.0'
	settings:
	autoInstallPeers: true
	excludeLinksFromLockfile: false

but in the ci, we still use the outdated pnpm, outdated pnpm cannot follow the locked dependencies, it will install the latest dependencies and it will caused typescript types error. Because it will install the latest antd, but we developed the dashboard with a stable version of antd, and ci will fail finally.

As for when will the newer pnpm-lock file be introducted, I think it's in some special time, the latest antd is compatible with the antd which we used, so the pnpm-lock file be merged.

[warjiang]

for the better way of pnpm management, we should follow the packageManager field in package.json

dashboard/ui/package.json

Lines 31 to 38 in 185adbd

	},
	"dependencies": {
	"dayjs": "^1.11.11"
	},
	"packageManager": "[email protected]",
	"pnpm": {
	"patchedDependencies": {
	"[email protected]": "patches/[email protected]"

[RainbowMango]

The pnpm version should follow the one from package.json, right?

dashboard/ui/package.json

Line 35 in 185adbd

"packageManager": "[email protected]",

[warjiang]

exactly~

[warjiang]

one of best practice is corepack=> https://github.com/nodejs/corepack

[RainbowMango]

So, how about adding one comment on it? like:

Suggested change

	version: 9.1.2
	# keep in sync with the packageManager version in ui/package.json
	version: 9.1.2

[warjiang]

So, how about adding one comment on it? like:

+1
BTW, can I use your suggestion code directly on github, will it cause some DCO problem ?

[RainbowMango]

May met the DCO problem and we have add the same comment at all 3 places, so I'd suggest go with a manual push.

[warjiang]

done~

[RainbowMango]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment