-
Notifications
You must be signed in to change notification settings - Fork 59
feat(docker): add multi-arch for terminal & extra manual trigger for … #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…build terminal image Signed-off-by: warjiang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @RainbowMango @samzong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
A little surprised, as I thought we supported multi-arch already.
it's new images, we introducte the new image called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not put this to the existing dockerhub-released-image.yml
that is designed to hold all images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the karmada-dashboard-terminal use ttyd as base image, not build on top of dashboard binary or static file, it will be released by manual trigger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can talk about it at this week's meeting.
What type of PR is this?
Add multi-arch support for karmada-dashboard-terminal image, btw we add extra manual trigger for build latest image.
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: