Skip to content

feat(docker): add multi-arch for terminal & extra manual trigger for … #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

warjiang
Copy link
Contributor

@warjiang warjiang commented Jul 7, 2025

What type of PR is this?
Add multi-arch support for karmada-dashboard-terminal image, btw we add extra manual trigger for build latest image.

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 7, 2025
@karmada-bot karmada-bot requested review from devadapter and samzong July 7, 2025 03:49
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from warjiang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 7, 2025
@warjiang
Copy link
Contributor Author

warjiang commented Jul 7, 2025

/assign @RainbowMango @samzong

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

A little surprised, as I thought we supported multi-arch already.

@warjiang
Copy link
Contributor Author

warjiang commented Jul 7, 2025

/assign

A little surprised, as I thought we supported multi-arch already.

it's new images, we introducte the new image called ttyd which is used in karmada control plane and cluster management. We'll add some extra feature like add karmadactl binary、trzsz compability for better experience ~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not put this to the existing dockerhub-released-image.yml that is designed to hold all images?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the karmada-dashboard-terminal use ttyd as base image, not build on top of dashboard binary or static file, it will be released by manual trigger.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can talk about it at this week's meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants