Skip to content

Update resource-propagating.md #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update resource-propagating.md #782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/userguide/scheduling/resource-propagating.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ For example, when using `SpreadByFieldRegion` to specify region groups, at the m

It has two replicaSchedulingTypes which determine how the replicas are scheduled when Karmada propagates a resource:

* `Duplicated`: duplicate the same replicas to each candidate member cluster from resources.
* `Duplicated`: duplicate the same replicas to each candidate member cluster from resources. This is the <b> default </b> `replicaSchedulingType`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the comments of ReplicaSchedulingType, the default should be Divided:
https://github.com/karmada-io/karmada/blob/58c3765684d386473d77a904652bb5fab272e375/pkg/apis/policy/v1alpha1/propagation_types.go#L554

Copy link
Contributor Author

@LavredisG LavredisG Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that there is a mistake there? This is a local test I did:

image
image

Besides, if Divided is default, it would have to specify a default ReplicaDivisionPreference besides the Type, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'm surprised but thanks for letting me know. I will explore it further.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I revisited the previous discussion and we made the consensus that if replicaScheduling == null, the default behavior is Duplicated, otherwise the default behavior is Divided.

Maybe we need to update the comments on API definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which Preference would be chosen in the case that default behavior is Divided?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Since your test above omit the replicaScheduling, it defaults to Duplicated, the behavior is expected. (We made a mistake on the API part, hopefully to fix it on next API version, like v1alpha2 or beta.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understandable! However, in the case that we have for example replicaScheduling == test, then as you said since it is not null, it will default to Divided. But Divided requires a preference, either Aggregated or Weighted if I am not mistaken, so which one of these would be chosen in that case?

* `Divided`: divide replicas into parts according to numbers of valid candidate member clusters, and exact replicas for each cluster are determined by `ReplicaDivisionPreference`.

`ReplicaDivisionPreference` determines how replicas are divided when ReplicaSchedulingType is `Divided`.
Expand Down