Lighter refactoring. Open up for creatig a "chat" mode. #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I think we'll need to do a refactor like this a bit in run.c. This change is also intertwined with the other PR that tries to create an |
|
That proposal was mine but I thought it was considered too invasive. |
rdentato
force-pushed
the
patch-light-refactor
branch
from
20d5ed7
to
57bf0e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal keeps the main() function in run.c structurally identical (i.e. all the variables are declared in the main, no addition of extra types, etc).
If something like this can be implemented,i it will be easier to create a chat (with history, the ability to change parameters from one prompt to another etc).
Just a proposal to help deciding which way to go.